Skip to content

[FIXED] Attempt stream snapshot on shutdown #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

[FIXED] Attempt stream snapshot on shutdown #6942

merged 1 commit into from
Jun 4, 2025

Conversation

MauriceVanVeen
Copy link
Member

When shutting down the stream would not be snapshotted. Either the monitor would close first and doSnapshot would not be called, or there would be a race with the Raft node being stopped and InstallSnapshot becoming a no-op.

Relates to #6279

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner June 4, 2025 16:57
derekcollison
derekcollison approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neilalexander
neilalexander approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit facc0a5 into main Jun 4, 2025
68 of 70 checks passed
@neilalexander neilalexander deleted the maurice/shutdown-snapshot-stream branch June 4, 2025 18:30
@neilalexander neilalexander mentioned this pull request Jun 17, 2025
Merged
neilalexander added a commit that referenced this pull request Jun 17, 2025
@neilalexander
Cherry-picks for 2.11.5-RC.1 (#6985)
cd8f3f8 
Includes the following:

- #6922
- #6931
- #6933
- #6934
- #6939
- #6938
- #6940
- #6941
- #6942
- #6943
- #6945
- #6944
- #6947
- #6948
- #6949
- #6956
- #6960
- #6961
- #6951
- #6965
- #6968
- #6981
- #6983
- #6984

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauriceVanVeen @derekcollison @neilalexander